Make sure that light and dark mode colors are being used throughout the app

[andrewtavis]

Terms

• I have searched open and closed design issues
• I agree to follow Scribe-Android's Code of Conduct

Description

In some instances the colors that are being used in the app are the same for both light and dark mode. We should check to make sure that we're using colors that are reactive to light and dark mode, with one instance being the grey for the tab bar icons when the options aren't selected. The colors that should be used in the app can be found in the Figma designs.

Contribution

Happy to support with this as I can and review a PR! 🎨

[andrewtavis]

CC @DeleMike, would you want to look into this? :) First thing would be to figure out which colors aren't reactive.

[DeleMike]

Yeah, I will look into this. Thanks!

[DeleMike]

Hello @andrewtavis , I'm so sorry this took a bit of time. I was really engaged with other things.

In some instances the colors that are being used in the app are the same for both light and dark mode.

For this task, I have pulled the latest source code, and I do not see the issue. I think the bottom nav bar issue I fixed earlier resolves the only issue related to this issue.

Have you run through the app to check if there are any specific screens that have this issue? I have gone through it and I can't find.

Thanks.

[andrewtavis]

No stress, @DeleMike! Just checking, this is specifically checking that we have no instances where the same color is being used in light and dark mode. All colors in the app should have light and dark mode variants. Is this the case?

[andrewtavis]

Might make sense to look into #358 in the meantime once we finalize the assessment here :)

[DeleMike]

No stress, @DeleMike! Just checking, this is specifically checking that we have no instances where the same color is being used in light and dark mode. All colors in the app should have light and dark mode variants. Is this the case?

Yes, for now I have checked everything and all seems good. But you can check too.

I will definitely check out #358

[andrewtavis]

I'll look into this and likely close it then. Thanks for the heads up, @DeleMike!

[angrezichatterbox]

Hey @DeleMike, There is an instance where the app shows a change in the color of the keyboard when in light and dark mode. When the overall mode is light and the app mode is in dark. The scribe keys are not in the right color in the keyboard. This could be one of the things to be checked out.