Skip to content

Conversation

@DeleMike
Copy link
Collaborator

Contributor checklist


Description

This PR is to fix scribe action button theme color to priortise app's theme mode over system mode.

Video demo below

Screenrecorder-2025-05-31-15-24-51-84.mp4

see screenshot to verify
Scribe btn theme when keyboard is in dark mode
screenshot 2025-05-31 at 15 34 44

Scribe btn theme when keyboard is in light mode
Screenshot 2025-05-31 at 15 35 58

Also, please describe shortly how you tested that your change actually works.

Related issue

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented May 31, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Collaborator Author

Hi @andrewtavis @angrezichatterbox this is the fix for #360 , what do you think?

@andrewtavis
Copy link
Member

Thanks for the great efforts here, @DeleMike! One thing I'm seeing is that we need to consider this for the other Scribe blue keys on the keyboard. This is what we have for dark mode for the device and light mode for the keyboard, where we can see that the command button colors aren't correct either. Specifically we also need to make sure that the enter button when the keyboard is in command mode is also the correct color - so when we press the Scribe key and then select a command, the enter key changes color to Scribe blue and has a play icon on it. This blue should match the Scribe key. Note that I haven't tested this explicitly, but we should check to make sure that it works 😊

Screenshot_20250531_222614

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 4, 2025

Thanks @andrewtavis , I understand some things.

A few questions:

  • We need to update the other scribe blue keys to match the main Scribe action button, yes?
  • when we press the scribe blue button, the keyboard enters command mode, right?
  • then when we select, for example, "plural" in command mode, we should change the enter button icon to a "play" icon and also its color, right?
  • finally, I will also look out if there are anything that needs improvement in the keyboard and also suggest it.

this is what we want now, right?


the scribe action buttons

Screenshot 2025-06-04 at 07 08 04

The enter key color
Screenshot 2025-06-04 at 07 08 13

This is the Figma design for the keyboard when in light mode.

Screenshot 2025-06-04 at 07 12 16

@andrewtavis
Copy link
Member

Hey @DeleMike 👋 Answers to your questions 😊

We need to update the other scribe blue keys to match the main Scribe action button, yes?

Yes, the Scribe Key, all command keys (translate, conjugate and plural) and enter while in command mode should all be the same color blue for light and dark mode, and this color should be first controlled by the app color and second controlled by the system color.

When we press the scribe blue button, the keyboard enters command mode, right?

Exactly :) I'll type out some vocabulary: The Top left button is the Scribe key, and pressing that enters command mode where the buttons for the commands are shown. When pressing any command button we see the command bar and the enter key changes color to indicate that the command can be executed.

Then when we select, for example, "plural" in command mode, we should change the enter button icon to a "play" icon and also its color, right?

Exactly. This color change is already being done, but we need to make sure that the color of Scribe blue is consistent with the Scribe key and command keys. Note that we don't want the enter key to always be Scribe blue. We only want this change to happen when a command has been selected in command mode :)

Finally, I will also look out if there are anything that needs improvement in the keyboard and also suggest it.

Thank you so much! 😊

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 6, 2025

Thanks! looking into it!

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 9, 2025

Hi @andrewtavis , this was already the case. It already had the same colour.

see my what I see on my test device:

Light Mode Dark Mode
Light 1 Dark 1
Light 2 Dark 2

I have tested it and the colour is consistent. Can you confirm from your end again?

@andrewtavis
Copy link
Member

Can you try changing the color mode of the device and for Scribe and seeing if they're consistent, @DeleMike? I'm still seeing that sometimes the colors are not matching up if the system color and app color don't match. See below:

Screenshot_20250609_144557

Screenshot_20250609_145447

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 9, 2025

hmm...I will do a lot of tests again
I will try to find the issue.

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 9, 2025

so, I checked the app.
It happens when the system is in dark mode. When the system is in light mode, it behaves as expected.

I will try to resolve it.

@DeleMike
Copy link
Collaborator Author

DeleMike commented Jun 9, 2025

Hi @andrewtavis , I have made an update. Please review.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working really well, @DeleMike! Thanks so much for the fix here! So great to have the UI so consistent now 😊

@andrewtavis andrewtavis merged commit 6a7bb20 into scribe-org:main Jun 9, 2025
5 checks passed
@DeleMike DeleMike deleted the fix/scribe-btn-color-on-keyboard branch June 9, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure that light and dark mode colors are being used throughout the app

2 participants