-
Notifications
You must be signed in to change notification settings - Fork 93
change unselected color and remove tab bar animation #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
Screenrecorder-2025-04-05-10-17-04-49.mp4@andrewtavis , what do you think of this? Do you think this shade of grey is good enough? |
|
I think it's looking great, @DeleMike! Let's fix the linting errors and then we can work to bring this in 🚀 |
|
Hii @andrewtavis, The PR is ready for review. What do you think about the bottom bar? |
|
Will finalize this tonight or tomorrow, @DeleMike! Thanks for the help here! 😊 |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's looking great here, @DeleMike! Let's maybe look into whether light and dark mode colors are being used throughout the app :) I'll make an issue for this and maybe you could check it out?
Sorry for the wait! 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Related issue