Skip to content

Henrikth93 linting check #12#14

Merged
wkyoshida merged 7 commits into
scribe-org:mainfrom
henrikth93:henrikth93-linting-check-#12
Sep 1, 2024
Merged

Henrikth93 linting check #12#14
wkyoshida merged 7 commits into
scribe-org:mainfrom
henrikth93:henrikth93-linting-check-#12

Conversation

@henrikth93

Copy link
Copy Markdown
Member

Contributor checklist


Description

Related issue

Added a golang lint
Added the function testlinter to test the linter.
Implemented pre-commit hooks
Removed test function
@github-actions

github-actions Bot commented Apr 1, 2024

Copy link
Copy Markdown

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
andrewtavis requested a review from wkyoshida August 31, 2024 15:27
@andrewtavis

Copy link
Copy Markdown
Member

As discussed in the org sync just now, we'll revert the changes back to d58ed3c and then do any updates to the workflow that are needed, such as updating the PR types as in Scribe-iOS/.github/workflows/pr_swiftlint.yaml. Let us know if there's anything we can do to help, @wkyoshida!

uses: golangci/golangci-lint-action@v6
with:
version: v1.60
only-new-issues: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes as per #14 (comment) - though looking at this again.. decided to actually consolidate the initial linting changes into the existing workflow, pr_ci.yaml.


The additional modification to note here is this only-new-issues option, which is to configure golangci-lint-action to only act on the new changes of a PR.

@wkyoshida
wkyoshida merged commit fc42ac0 into scribe-org:main Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants