Henrikth93 linting check #12#14
Conversation
Added a golang lint
Added the function testlinter to test the linter.
Implemented pre-commit hooks
Removed test function
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
|
As discussed in the org sync just now, we'll revert the changes back to d58ed3c and then do any updates to the workflow that are needed, such as updating the PR types as in Scribe-iOS/.github/workflows/pr_swiftlint.yaml. Let us know if there's anything we can do to help, @wkyoshida! |
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v1.60 | ||
| only-new-issues: true |
There was a problem hiding this comment.
Made the changes as per #14 (comment) - though looking at this again.. decided to actually consolidate the initial linting changes into the existing workflow, pr_ci.yaml.
The additional modification to note here is this only-new-issues option, which is to configure golangci-lint-action to only act on the new changes of a PR.
Contributor checklist
Description
Related issue