Add pre-commit hook for gofmt#26
Conversation
Thank you for the pull request! ❤️The Scribe-Server team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
As the license_header_check error occurred, If the PR approved, we might marge this PR before #23. |
|
@axif0, don't we also want a GitHub Action in the |
|
Or I guess ultimately the beauty of the Makefile is that people have to install these, so it's not the case like pre-commit that we need to check on PRs as well if they didn't install :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks for the changes here, @axif0! I removed the echo for trimming whitespace as it didn't make sense to me, but if it's needed then feel free to add it in to the other PR 😊
|
Merging this in and we can get the license headers from #23 as suggested :) |
Contributor checklist
Description
Related issue