Skip to content

fix: #MARK large Go files#47

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
DeleMike:fix/add-mark-comments
Oct 22, 2025
Merged

fix: #MARK large Go files#47
andrewtavis merged 2 commits into
scribe-org:mainfrom
DeleMike:fix/add-mark-comments

Conversation

@DeleMike

Copy link
Copy Markdown
Collaborator

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

Description

I have added #MARK to some Go files I felt it was necessary. Please feel free to tell me what other files I should mark out.

Related issue

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙

The Scribe-Server team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Data rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Oct 19, 2025

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
  • The continuous integration (CI) workflows within the PR checks do not indicate new errors in the files changed

@DeleMike

Copy link
Copy Markdown
Collaborator Author

Hi @axif0, could you help review this PR?

I have added #MARK to some Go files. Please don't hesitate to tell me what other files I should mark out.

cc: @andrewtavis

@andrewtavis
andrewtavis self-requested a review October 19, 2025 21:40
@andrewtavis

Copy link
Copy Markdown
Member

note: From my end this is looking great and really helps structure the code better 😊 @axif0, could you give it a quick glance to see if this makes sense or if anything else is needed?

suggestion/praise: Let's not worry too much about this, and I really do appreciate you adding in this section based documentation to the code! 😊

@DeleMike

Copy link
Copy Markdown
Collaborator Author

Thanks @andrewtavis 🎉🎉

@axif0 axif0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged 🚀

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! 😊🚀

@andrewtavis
andrewtavis merged commit 26a4021 into scribe-org:main Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MARK: out some of the larger Go files

3 participants