ci: remove redundant town-crier announce-pr producer#142
Conversation
Town-crier now announces PRs via its GitHub App (installed org-wide), which covers announce/resolve/consensus for every repo. This per-repo producer workflow is now redundant and fires a SECOND /announce to the bus on every Agent Review Requested label and push/synchronize event, double-posting on every PR/label event. Removing it stops the duplication; the App is the single producer going forward. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rn34Ujm47YgQedoudDFiJW
Deploying fs-packages with
|
| Latest commit: |
e9e8d76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a1fe912.fs-packages.pages.dev |
| Branch Preview URL: | https://ci-remove-announce-pr-produc.fs-packages.pages.dev |
Town Crier Review · 9/10 · PASS · 🔎 Independentfs-packages #142 · AC anchor: PR description · head Tip Config-only PR deleting the per-repo town-crier No findings — clean against the review checklist. |
Goosterhof
left a comment
There was a problem hiding this comment.
✅ Approve-worthy
0 blockers · 0 concerns · 1 nit · 1 praise · 0 inline
Confirms @dispatch's bus review (PASS, no findings) — and closes their one residual.
Pure deletion of .github/workflows/announce-pr.yml (155 lines, one commit, 0 additions). The "redundant" claim holds, and the per-repo CI/publish gates (ci.yml, publish.yml) are untouched — only the producer copy goes. Required checks are green (Cloudflare Pages + check).
The dispatch review parked one residual as "unfalsifiable" — whether the org-wide GitHub App producer (TC-0014/ADR-0036) is actually installed-and-live on this repo, since deleting the workflow with no live App behind it would leave an announce gap, not a redundancy. That residual is in fact falsified in the PR's favor by its own evidence: the bus is currently seeing double-announces, and a double-post is direct proof the App is already producing for this repo. Removing this workflow therefore demotes a confirmed-firing pair to a single confirmed-firing producer — no gap.
Nit: the body's "stopping the duplicate announce" is true only scoped to fs-packages. This is one slice of the 14-repo decommission; the other producer copies keep double-announcing until each is removed. Incremental is fine — just don't read this PR as fleet-complete.
Praise: the timing. The App-producer decommission is correctly riding the 2026-06-29 town-crier cutover that made the App prod-live; pulling this workflow before that landed would have opened exactly the gap the dispatch review worried about.
Automated war-room agent review — posted because this PR carries the Agent Review Requested label.
Deletes the per-repo town-crier producer workflow
.github/workflows/announce-pr.yml.Why
Town-crier now announces PRs via its GitHub App (installed org-wide), which covers announce / resolve / consensus for every repo centrally. This per-repo producer workflow is now redundant: it fires a second
/announceto the bus on everyAgent Review Requestedlabel and push/synchronize event, double-posting on every PR/label event (the announce spam currently visible on the bus).Removing it leaves the GitHub App as the single producer going forward, stopping the duplicate announce.
Change
git rm .github/workflows/announce-pr.yml— exactly one file deleted (155 lines), nothing else.Notes
No
Agent Review Requestedlabel on this PR — applying it would trigger the very double-announce this PR removes. For direct user merge.