Skip to content

ci: remove redundant town-crier announce-pr producer#142

Merged
Goosterhof merged 1 commit into
mainfrom
ci/remove-announce-pr-producer
Jun 30, 2026
Merged

ci: remove redundant town-crier announce-pr producer#142
Goosterhof merged 1 commit into
mainfrom
ci/remove-announce-pr-producer

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

Deletes the per-repo town-crier producer workflow .github/workflows/announce-pr.yml.

Why

Town-crier now announces PRs via its GitHub App (installed org-wide), which covers announce / resolve / consensus for every repo centrally. This per-repo producer workflow is now redundant: it fires a second /announce to the bus on every Agent Review Requested label and push/synchronize event, double-posting on every PR/label event (the announce spam currently visible on the bus).

Removing it leaves the GitHub App as the single producer going forward, stopping the duplicate announce.

Change

  • git rm .github/workflows/announce-pr.yml — exactly one file deleted (155 lines), nothing else.

Notes

No Agent Review Requested label on this PR — applying it would trigger the very double-announce this PR removes. For direct user merge.

Town-crier now announces PRs via its GitHub App (installed org-wide),
which covers announce/resolve/consensus for every repo. This per-repo
producer workflow is now redundant and fires a SECOND /announce to the
bus on every Agent Review Requested label and push/synchronize event,
double-posting on every PR/label event. Removing it stops the
duplication; the App is the single producer going forward.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rn34Ujm47YgQedoudDFiJW
@jasperboerhof jasperboerhof requested a review from a team as a code owner June 29, 2026 17:46
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploying fs-packages with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9e8d76
Status: ✅  Deploy successful!
Preview URL: https://4a1fe912.fs-packages.pages.dev
Branch Preview URL: https://ci-remove-announce-pr-produc.fs-packages.pages.dev

View logs

@jasperboerhof jasperboerhof added the Agent Review Requested Requesting review of specialized AI review agents. label Jun 29, 2026
@jasperboerhof

Copy link
Copy Markdown
Contributor Author

Town Crier Review · 9/10 · PASS · 🔎 Independent

fs-packages #142 · AC anchor: PR description · head e9e8d768a3 · via the town-crier bus (request #31)

Tip

Config-only PR deleting the per-repo town-crier announce-pr.yml producer; I verified the "redundant" claim and it holds — the bus now ingests pull_request/pull_request_review events server-side via a GitHub App webhook (town-crier:backend/app/Http/Controllers/GithubWebhookController.php, TC-0014/ADR-0036) that covers the same announce/resolve/consensus duties, the deletion is clean and scoped to one commit with no dangling references, and it touches no published @script-development/fs-* API. The only residual (whether the App is installed-and-live on fs-packages) is an unfalsifiable deployment-timing question with no code evidence, so it's not a finding.

No findings — clean against the review checklist.

@Goosterhof Goosterhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve-worthy

0 blockers · 0 concerns · 1 nit · 1 praise · 0 inline
Confirms @dispatch's bus review (PASS, no findings) — and closes their one residual.

Pure deletion of .github/workflows/announce-pr.yml (155 lines, one commit, 0 additions). The "redundant" claim holds, and the per-repo CI/publish gates (ci.yml, publish.yml) are untouched — only the producer copy goes. Required checks are green (Cloudflare Pages + check).

The dispatch review parked one residual as "unfalsifiable" — whether the org-wide GitHub App producer (TC-0014/ADR-0036) is actually installed-and-live on this repo, since deleting the workflow with no live App behind it would leave an announce gap, not a redundancy. That residual is in fact falsified in the PR's favor by its own evidence: the bus is currently seeing double-announces, and a double-post is direct proof the App is already producing for this repo. Removing this workflow therefore demotes a confirmed-firing pair to a single confirmed-firing producer — no gap.

Nit: the body's "stopping the duplicate announce" is true only scoped to fs-packages. This is one slice of the 14-repo decommission; the other producer copies keep double-announcing until each is removed. Incremental is fine — just don't read this PR as fleet-complete.

Praise: the timing. The App-producer decommission is correctly riding the 2026-06-29 town-crier cutover that made the App prod-live; pulling this workflow before that landed would have opened exactly the gap the dispatch review worried about.

Automated war-room agent review — posted because this PR carries the Agent Review Requested label.

@Goosterhof Goosterhof merged commit 9f3dd2e into main Jun 30, 2026
2 checks passed
@Goosterhof Goosterhof deleted the ci/remove-announce-pr-producer branch June 30, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Requesting review of specialized AI review agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants