Validate pattern schemas and diagnose configuration typos - #16
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misspelled language names and unknown TOML fields were silently ignored, allowing invalid custom configuration to produce a successful empty inventory. Schema versions were parsed but never checked, and regex failures did not identify their owning rule.
Reject unknown fields at every schema level, unsupported schema versions, empty names/language lists, and unrecognized language names. Regex errors identify the library, algorithm, and parameter. Validate reserved Kotlin/Erlang definitions while preserving their existing inactive status; disabled Cargo languages remain valid configuration.
Document the accepted schema and current limitations. Existing duplicate algorithm definitions and parameter regexes without captures remain compatible; tightening those requires separate catalog evidence and review.
Validation: seven configuration regression tests, complete all-feature and minimal-feature tests, formatting, and all-target Clippy with warnings denied in both configurations. The bundled catalog and all ground-truth fixtures pass unchanged.
Part 3 of the review series; independently based on
main. Related: #14 and #15.