Skip to content

hardfork: GalileoV2 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 27, 2025
Merged

hardfork: GalileoV2 #236

merged 7 commits into from
Nov 27, 2025

Conversation

@roynalnaruto
Copy link
Collaborator

@roynalnaruto roynalnaruto commented Nov 26, 2025 •
edited by lispc
Loading

@github-actions github-actions bot added the crate-integration Updates to the integration crate label Nov 26, 2025
@github-actions github-actions bot added the crate-prover Updates to the prover crate label Nov 27, 2025
noel2004
noel2004 reviewed Nov 27, 2025
View reviewed changes
crates/prover/src/utils/vm.rs
pub fn execute_guest(
sdk: &Sdk,
exe: impl Into<ExecutableFormat>,
vm_config: SdkVmConfig,
Copy link
Member

@noel2004 noel2004 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to downgrade the execute_guest. The issue about all 0 PI has been confirmed as limited (only raised when "legacy-v1-3 feature is applied and a guest built by openvm 1.3 is loaded. We can walk through this compatibility feature soon.

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Nov 27, 2025
@lispc lispc marked this pull request as ready for review November 27, 2025 13:25
@Thegaram Thegaram mentioned this pull request Nov 27, 2025
Merged
@lispc lispc merged commit 85dc6bc into master Nov 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noel2004 noel2004 noel2004 left review comments

@lispc lispc Awaiting requested review from lispc lispc is a code owner

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

Assignees

No one assigned

Labels

crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roynalnaruto @noel2004 @lispc