check allowance expiration before increasing or decreasing it #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenpo
commented
May 27, 2021
Comment on lines
995
to
997
|
|
||
| if allowance.expiration.map(|ex| ex < env.block.time) == Some(true) && allowance.amount != 0 { | ||
| allowance.amount = 0; | ||
| write_allowance(storage, owner, spender, allowance)?; | ||
| if allowance.is_expired_at(&env.block) { | ||
| return Err(insufficient_allowance(0, amount)); |
There was a problem hiding this comment.
Note to reviewer: This code segment was expensive and unnecessary. There's no need to actively set the amount to 0 if the allowance query would make it clear to consumers that the allowance has expired anyway (so the amount isn't important)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements only the bug fix from #16 .
The bug was that if allowance is increased or decreased after the previously provided allowance has expired, then the allowance didn't reset and the new allowance would be added or deducted from the expired allowance.