This repository was archived by the owner on Feb 15, 2026. It is now read-only.
fix(middleware): enhanced user privacy on profile pages#3695
Closed
fallenbagel wants to merge 1 commit intosct:developfrom
Closed
fix(middleware): enhanced user privacy on profile pages#3695fallenbagel wants to merge 1 commit intosct:developfrom
fallenbagel wants to merge 1 commit intosct:developfrom
Conversation
Addresses a security vulnerability where the `/users/[:id]` route was accessible to users without the necessary permissions. Adds middleware that protects that route so that only authenticated users with the `MANAGE_USERS` and `VIEW_WATCHLIST` permissions can access other user's profile pages as intended.
fallenbagel
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
Collaborator
|
The current behavior is the intended behavior. The content visible on profile pages is dependent on the active user's permissions. |
Contributor
Author
Ah I see. This was raised because there were users who wanted the usernames/pfps and such to not be exposed to other users unless given the permission to do so as it concerns privacy Alright will close this c: |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses a security vulnerability where the
/users/[:id]route was accessible to users without the necessary permissions. Adds middleware that protects that route so that only authenticated users with theMANAGE_USERSandVIEW_WATCHLISTpermissions can access other user's profile pages as intended.(unless if the current behavior is the intended behavior, then feel free to close the PR 😄 ).
To-Dos
yarn build