fix: add flag in local storage for notifications #4180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: update comment
overseerr
|
||||||||||||||||||||||||||||
| Project |
overseerr
|
| Branch Review |
refs/pull/4180/merge
|
| Run status |
|
| Run duration | 02m 34s |
| Commit |
|
| Committer | Brandon Cohen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
28
|
| View all changes introduced in this branch ↗︎ | |
sct
approved these changes
Jul 3, 2025
OwsleyJr
added a commit
that referenced
this pull request
Oct 8, 2025
* fix: add flag in local storage for notifications refactor: update comment * fix: always resubscribe if subscription is not valid
ThePharmer
pushed a commit
to ThePharmer/requesterr
that referenced
this pull request
Nov 12, 2025
Syncs fork with upstream Overseerr develop branch, bringing in 18 bug fixes and improvements from commits 4cc3495..5ef098f. Key upstream improvements merged: - fix(api): update Plex Watchlist URL (sct#4220) - fix: add flag in local storage for notifications (sct#4180) - fix: add push subscription verification and resubscribe logic (sct#4163) - fix: better handling for active webpush subscription (sct#4146) - fix: handle partial seasons more reliably (sct#4116) - refactor(MediaRequest): consolidate lifecycle hooks (sct#4124) - Multiple webpush notification improvements - Media entity cascade fixes - Various UI and request handling fixes Conflicts resolved: - README.md: Preserved Requesterr fork branding and attribution All Requesterr branding (translations, CSS classes, settings) remains intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So push subscriptions are quite tricky, especially on webkit as it will randomly set the current subscription to null at random while there seems to be no issues with chrome based browsers. The previous PR was pushed up just to test and verify that this was happening.
With the current logic already in place, we can now just add a local storage flag on the user device denoting if push notifications are enabled or not. This will allow us to resubscribe if the subscription becomes null.
Screenshot (if UI-related)
N/A
To-Dos
yarn build