Merged
Conversation
added 2 commits
April 5, 2023 11:15
…andas 2.0 upgrade
…t copy anndatas with empty indexes
maikia
approved these changes
Apr 6, 2023
pydeseq2/dds.py
Outdated
| # Only replace if genes are not all zeroes after outlier replacement | ||
| to_replace[to_replace] = ~new_all_zeroes | ||
|
|
||
| print(to_replace) |
Collaborator
Author
There was a problem hiding this comment.
Indeed, you caught me red-handed doing print debugging :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR implement? Be specific.
This PR fixes bugs when using
pydeseq2withpandas2.0.Code to reproduce the issue
First bug
would output
Second bug
After fixing the first bug,
DeseqDataSet.refit()would throwanndata.ImplicitModificationWarnings, making the tests fail.Fix
The first bug is caused by
pydeseq2.utils.build_design_matrixoutputting boolean columns withpandasAPI changes. This PR fixes it by casting the design matrix to int, which is compatible with older versions ofpandas.The second bug arrises when copying anndata objects with empty indexes. This PR fixes it by checking that indexes are non-empty prior to copying.