Expand anndata compatibility#115
Merged
BorisMuzellec merged 9 commits intoscverse:mainfrom Apr 26, 2023
Merged
Conversation
scottgigante-immunai
requested review from
BorisMuzellec,
arthurPignetOwkin and
maikia
as code owners
Collaborator
|
Hi @scottgigante-immunai, thanks for opening this PR! I agree that it would be best to use the latest version of Unfortunately I probably won't have much time to work on this in the next few days/weeks, but if you feel like investigating why tests fail, I'd be happy to review this PR once it passes tests. In the meantime, I can also help to some extent. |
dtype argument with be deprecated in anndata 0.10
Contributor
Author
|
Thanks @BorisMuzellec ! Looks like I need your approval to run the tests, but otherwise I'm happy to debug. |
Contributor
Author
|
@BorisMuzellec this should be good to go :) |
BorisMuzellec
requested changes
Apr 26, 2023
BorisMuzellec
approved these changes
Apr 26, 2023
Collaborator
BorisMuzellec
left a comment
BorisMuzellec
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot @scottgigante-immunai for your help, it's always awesome to have new contributors!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #114
What does your PR implement? Be specific.
Expands anndata compatibility