BUG fix deseq2_norm bug when applied to a pandas dataframe#127
Merged
BorisMuzellec merged 5 commits intomainfrom May 4, 2023
Merged
BUG fix deseq2_norm bug when applied to a pandas dataframe#127BorisMuzellec merged 5 commits intomainfrom
deseq2_norm bug when applied to a pandas dataframe#127BorisMuzellec merged 5 commits intomainfrom
Conversation
maikia
approved these changes
May 4, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
LGTM, thanks @BorisMuzellec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #122
What does your PR implement? Be specific.
This PR:
deseq2_normon a pandas dataframe, by checking whether the argument is a dataframe (in which case indexing is done with.locor a ndarray).