Merged
Conversation
emmcauley
requested review from
BorisMuzellec,
arthurPignetOwkin and
maikia
as code owners
Collaborator
|
Thanks a lot for this PR @emmcauley, I'll have a look at it ASAP. |
added 5 commits
June 7, 2023 12:00
Collaborator
|
@emmcauley I made a few minor changes to allow users to pass arguments to Thanks again for your contribution! |
Contributor
Author
|
@BorisMuzellec these changes are great, thanks for adding these options! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
This PR addresses issue #124 and implements functionality to create a dispersion plot (similar to
plotDispEsts()in DESeq2).What does your PR implement? Be specific.
PR includes a
make_scatter()function (based on matplotlib) in utils.py that is then called byplot_dispersions()in dds.py.plot_dispersions()currently just graphs estimated, fitted, and final dispersions -- let me know if more flexibility would be appropriate. Also, I'm happy to add any documentation and address any feedback/further changes you'd like to see in the code!