MAINT turn rank deficiency exception to warning#139
Merged
BorisMuzellec merged 2 commits intomainfrom Jun 12, 2023
Merged
Conversation
ghost
approved these changes
Jun 8, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
@BorisMuzellec LGTM except for a minor comment
Comment on lines
1045
to
-1047
| "The design matrix is not full rank, so the model cannot be " | ||
| "fitted. Please remove the design variables that are linear " | ||
| "combinations of others." |
There was a problem hiding this comment.
This text is adapted to a valueError but not necessarily a warning. What do you think about toning down the message?
Collaborator
Author
There was a problem hiding this comment.
Thanks for your review! I've updated the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #136
What does your PR implement? Be specific.
Throw a
UserWarninginstead of aValueErrorwhen aDeseqDataSetis initialized with a rank-deficient design matrix.This allows users to run design-free VST without providing a full rank design (as described in #136).