Introduce quiet attribute to DeseqDataSet that is checked before printing status updates#146
Merged
BorisMuzellec merged 5 commits intoscverse:mainfrom Jul 17, 2023
noamteyssier:introduce-quiet-feature-to-deseq2-method
Merged
Introduce quiet attribute to DeseqDataSet that is checked before printing status updates#146BorisMuzellec merged 5 commits intoscverse:mainfrom noamteyssier:introduce-quiet-feature-to-deseq2-method
DeseqDataSet that is checked before printing status updates#146BorisMuzellec merged 5 commits intoscverse:mainfrom
noamteyssier:introduce-quiet-feature-to-deseq2-method
Conversation
noamteyssier
requested review from
BorisMuzellec,
arthurPignetOwkin and
maikia
as code owners
Collaborator
|
Hi @noamteyssier, thanks a lot for this PR, looks great! To make this PR complete, it would be nice if you had the time to extend it to |
Contributor
Author
|
No problem - just extended it to the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
This is in reference to issue #102, i.e. introducing a quiet parameter to suppress status updates.
What does your PR implement? Be specific.
self.quietbool attribute to theDeseqDataSetclassprintfirst check if theself.quietattribute is set and only print if sosys.stderras opposed to stdout (this wasn't in the issue but I find this to be more standard for status updates like this)