Merged
Conversation
added 10 commits
August 1, 2023 17:04
…tinguish between continuous and categorical covariates
BorisMuzellec
requested review from
arthurPignetOwkin and
maikia
as code owners
maikia
approved these changes
Aug 7, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
LGTM, thanks @BorisMuzellec
Co-authored-by: Maria Telenczuk <maria.telenczuk@owkin.com>
Co-authored-by: Maria Telenczuk <maria.telenczuk@owkin.com>
Collaborator
Author
|
Thanks for the review @maikia ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #100
What does your PR implement? Be specific.
This PR adds support for continuous covariates in PyDESeq2.
More precisely:
continuous_factorsargument was added toDeseqDataSetandutils.build_design_matrix, in which users may provide a list of design factors that should be considered as continuous / numerical;DeseqStatswas updated to account for continuous factors;