Fix: calculate Cooks distances with few samples #44
Merged
BorisMuzellec merged 4 commits intomainfrom Jan 13, 2023
Merged
Conversation
ghost
reviewed
Jan 12, 2023
Collaborator
Author
I guess we could add a test where the pipeline is run on a dataset with few samples, as the piece of code responsible for the bug only is run only when no cohort has 3 or more samples. Not sure what to test for though, would error-free execution be enough? |
Yes I think that simply adding this corner case and ensuring it runs without error is a good starting point! |
449442a to
580f216
Compare
added 2 commits
January 12, 2023 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the bug described in Issue #43.
The issue seemed to be that the summation was done on the wrong axis in the
trimmed_variancefunction, called throughrobust_method_of_moments_dispin thecalculate_cooksmethod of theDeseqDataSetclass.