BUG fix DeseqStats test of dds's replaced attribute#62
Merged
BorisMuzellec merged 3 commits intomainfrom Jan 27, 2023
Merged
Conversation
…nly be done when refit_cooks is true
maikia
reviewed
Jan 26, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
would it be feasible to add a test to it?
Collaborator
Author
|
Checking that the workflow |
maikia
approved these changes
Jan 27, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
Thanks @BorisMuzellec LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At initialization, a DeseqStats object should check that that the DeseqDataSet it is built from has a
replacedattribute, if it hasrefit_cooks=True.Up to now, it was checking this independently of
dds.refit_cooks. This small PR corrects this bug.