Merged
Conversation
added 30 commits
January 16, 2023 17:48
…n synthetic outlier-less dataset (wip)
added 2 commits
February 1, 2023 15:12
…nndata views as it leads to speed improvements
ghost
mentioned this pull request
ghost
reviewed
Feb 9, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Congrats for the big refactoring work @BorisMuzellec ! The code seems correct to me. I have many cosmetic remarks that we can discuss in the comments. I think we'll be able to merge at the second pass.
added 5 commits
February 13, 2023 16:07
ghost
approved these changes
Feb 16, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
🎉 Let's merge! Thanks for all the changes @BorisMuzellec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to support the AnnData data structure towards the integration of pydeseq2 to scverse (#15).
More precisely:
DeseqDataSetclass now extends theAnnDataclass. As such, it inherits from all methods and attributes ofAnnData, and parameters (such as size_factors and LFCs) are now stored in the relevantAnnDatafields (e.g.obsmandvarm),DeseqStatswas updated accordingly,AnnDataclass inheritance,