DEP removing the notebooksdirectory#67
Merged
BorisMuzellec merged 2 commits intomainfrom Jan 30, 2023
Merged
Conversation
… gallery instead
maikia
reviewed
Jan 27, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
LGTM, just unsure about the binder link
| This package is a python implementation of the [DESeq2](https://bioconductor.org/packages/release/bioc/html/DESeq2.html) method [1] | ||
| for differential expression analysis (DEA) with bulk RNA-seq data, originally in R. | ||
| This package is a python implementation of the [DESeq2](https://bioconductor.org/packages/release/bioc/html/DESeq2.html) | ||
| method [1] for differential expression analysis (DEA) with bulk RNA-seq data, originally in R. |
Collaborator
There was a problem hiding this comment.
not a scope of this PR but would be nice if there was a link to [1] leading to the references in the bottom of the page
README.md
Outdated
| You can run them directly in your browser: | ||
|
|
||
| [](https://mybinder.org/v2/gh/owkin/PyDESeq2/HEAD?labpath=notebooks%2Findex.ipynb) | ||
| [](https://mybinder.org/v2/gh/Owkin/PyDESeq2/5bf8ec61831abda43ab472517bf62c1d176b5043?urlpath=lab/tree/jupyter_notebooks/auto_examples/plot_minimal_pydeseq2_pipeline.ipynb) |
Collaborator
There was a problem hiding this comment.
I would remove it unless you are 100% sure this link won't change with new versions? I would guess that it does
Collaborator
Author
There was a problem hiding this comment.
Indeed, good point. Let me remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR implement? Be specific.
This PR removes the
notebooksdirectory and replaces references to it with links to the example gallery in the docs.Indeed, users discovering pydeseq2 should instead refer to the Getting Started examples from the docs.