Moving docs' requirements into the actual docs' requirements file#72
Conversation
maikia
left a comment
There was a problem hiding this comment.
@mandreux-owkin thanks for your contribution!
the cleaning up is a great idea, and it's true that gitpython and matplotlib should not be in setup.py if they are only used for docs.
but here it might be a bit more complex:
Sphinx is generating the docs, but we also use binder to run the example notebooks. (refer to .mybinder directory) There, in postbuild we are actually uninstalling all the docs/requirements to have a lighter build. I am afraid with this change the binder won't work. Feel free to suggest alternative solution.
|
@maikia thanks for your careful review. I checked the notebooks code and I am certain that |
maikia
left a comment
There was a problem hiding this comment.
LGTM, thanks @mandreux-owkin
Reference Issue or PRs
This PR is not linked to an existing issue.
What does your PR implement? Be specific.
This PR moves the specific requirements of the documentation (
matplotlibandgitpython) which are currently in thesetup.pyfile to thedocs/requirements.txtfile, which is more appropriate as they are not used elsewhere.