ENH implement a getter for normalized counts#79
Merged
BorisMuzellec merged 6 commits intomainfrom Feb 20, 2023
Merged
Conversation
ghost
reviewed
Feb 15, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Thanks @BorisMuzellec ! I have tiny remarks
Co-authored-by: mandreux-owkin <62643750+mandreux-owkin@users.noreply.github.com>
…ormed counts as a layers item
Collaborator
Author
|
Actually, I think that with the AnnData integration I think that the most natural way to access normalized counts is by setting a new layer, although this induces a memory overhead |
… fit_size_factors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #77.
What does your PR implement? Be specific.
This PR implements a getter for
DeseqDataSet's normalized counts.Thanks to the
@propertydecorator, normalized counts can be obtained as if they were aDeseqDataSetattribute (dds.normed_counts), without having to store them in memory. Instead, they are computed on-the-fly.