Merged
Conversation
BorisMuzellec
requested review from
arthurPignetOwkin and
maikia
as code owners
maikia
suggested changes
Feb 21, 2023
Co-authored-by: Maria Telenczuk <maria.telenczuk@owkin.com>
…or load from url)
maikia
suggested changes
Feb 21, 2023
tests/test_utils.py
Outdated
|
|
||
| # Mock the output of is_dir() as False to emulate not having access to the | ||
| # ``datasets`` directory | ||
| pathlib.Path.is_dir.return_value = [False, True] |
Collaborator
There was a problem hiding this comment.
this should be in parametrize (otherwise the value is [False, True]
maikia
approved these changes
Feb 21, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
LGTM, thanks @BorisMuzellec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR implement? Be specific.
This PR fixes the example gallery which causes the docs not to compile on readthedocs. This is due to a data importing issue after merging #68 (pandas won't load a csv from an url provided in the form of a
Path).A unit test was added to
test_utils.pyto check thatload_example_datacorrectly retrieves data from github when thedatasetsdirectory is not accessible (as when building the docs on RTD).