Merged
Conversation
BorisMuzellec
requested review from
arthurPignetOwkin and
maikia
as code owners
maikia
suggested changes
Mar 21, 2023
Collaborator
maikia
left a comment
maikia
left a comment
There was a problem hiding this comment.
Nice work. some minor comments before merge. Especially the test might need some improvement.
…utside of the loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #95
What does your PR implement? Be specific.
When each gene has at least one zero, it is not possible to compute size factors using the median of ratios method.
This PR implements an iterative MLE scheme to fit size factors when this happens (see #95).