Parallel IDF#404
Merged
kaizhang merged 2 commits intoscverse:mainfrom Jul 9, 2025
Merged
Conversation
Member
|
Hi Josh, thanks for the pull request! Have you tested if the new implementation produces the same output as the old one? And what is the performance gain for large datasets? |
Author
|
Hi Kai - I added a couple of tests with simulated matrices that show that the new implementation produces identical results to the old one. I haven't had a chance to benchmark performance gain, but previously the single threaded approach was stuck on the idf step for a ~10M x 1M matrix for about a week without finishing. With the parallel implementation it finished in < 8 hours using 48 CPUs. Results from the test: |
kaizhang
pushed a commit
that referenced
this pull request
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
idf_from_chunksis sequential, which makes the IDF step a bottleneck for very large matrices. This PR adds a version which parallelizes the IDF counting using existing Rayon imports, which should improve performance on large datasets.