Skip to content

fix: actually set the column to the in-memory data when shuffling by default#121

Merged
ilan-gold merged 4 commits intomainfrom
ig/in_mem_data
Jan 23, 2026
Merged

fix: actually set the column to the in-memory data when shuffling by default#121
ilan-gold merged 4 commits intomainfrom
ig/in_mem_data

Conversation

@ilan-gold
Copy link
Copy Markdown
Collaborator

@felix0097 Beyond this being a bug against the original intention, this should account for the performance drop we saw (and what I saw over what I tried out on DENBI). obs['foo'] = ... != `setattr(obs, 'foo', ...) agh!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (cbacf43) to head (a1bdcfc).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   94.22%   91.39%   -2.83%     
==========================================
  Files          10       10              
  Lines         744      744              
==========================================
- Hits          701      680      -21     
- Misses         43       64      +21     
Files with missing lines Coverage Δ
src/annbatch/io.py 94.71% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilan-gold ilan-gold added the skip-gpu-ci Whether gpu ci should be skipped label Jan 23, 2026
@ilan-gold ilan-gold marked this pull request as ready for review January 23, 2026 13:11
@ilan-gold ilan-gold merged commit 477236a into main Jan 23, 2026
12 of 13 checks passed
@ilan-gold ilan-gold deleted the ig/in_mem_data branch January 23, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-gpu-ci Whether gpu ci should be skipped

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant