feat: Make it optional to provide splits for Sampler in LoadRequest#127
Merged
feat: Make it optional to provide splits for Sampler in LoadRequest#127
splits for Sampler in LoadRequest#127Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 93.76% 91.06% -2.70%
==========================================
Files 10 10
Lines 770 795 +25
==========================================
+ Hits 722 724 +2
- Misses 48 71 +23
🚀 New features to boost your workflow:
|
ilan-gold
reviewed
Jan 28, 2026
Collaborator
ilan-gold
left a comment
There was a problem hiding this comment.
Big question is how to handle shuffle - user problem or ours?
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
…oaders into ff/make-splits-optional
ilan-gold
approved these changes
Jan 29, 2026
| @property | ||
| @abstractmethod | ||
| def shuffle(self) -> bool: | ||
| """Whether to shuffle data during sampling. |
Collaborator
There was a problem hiding this comment.
I would mention that we are interpreting this as shuffling in-memory, but it is up to the implementer to shuffle from the on-disk
Collaborator
There was a problem hiding this comment.
Also the bit about batch_size
ilan-gold
requested changes
Jan 29, 2026
ilan-gold
reviewed
Jan 29, 2026
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
ilan-gold
approved these changes
Jan 29, 2026
Collaborator
|
@felix0097 Can you add a changelog entry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it optional to provide
splitsin theannbatch.types.LoadRequest.The logic is the following:
splitsis provided -> use splitssplitsis not provided -> do random batching