Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 93.41% 91.00% -2.41%
==========================================
Files 10 10
Lines 805 823 +18
==========================================
- Hits 752 749 -3
- Misses 53 74 +21
🚀 New features to boost your workflow:
|
ilan-gold
reviewed
Feb 5, 2026
| X=g["X"] if isinstance(g["X"], zarr.Array) else ad.io.sparse_dataset(g["X"]), obs=ad.io.read_elem(g["obs"]) | ||
| X=g["X"] if isinstance(g["X"], zarr.Array) else ad.io.sparse_dataset(g["X"]), | ||
| obs=ad.io.read_elem(g["obs"]), | ||
| var=pd.DataFrame(index=pd.Index(g["var/_index"][:], name=g["var"].attrs.get("_index"))), |
Collaborator
There was a problem hiding this comment.
USe g["var"].attrs.get("_index") for getting the actual column i.e., g[f"var/{index_name_from_attrs}"]
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
ilan-gold
reviewed
Feb 10, 2026
Comment on lines
+534
to
+543
| # Test add_anndata raises error when adding second anndata with different var | ||
| loader = Loader(chunk_size=10, preload_nchunks=4, batch_size=20) | ||
| loader.add_anndata(adata1_on_disk) | ||
| with pytest.raises(ValueError, match="All datasets must have identical var DataFrames"): | ||
| loader.add_anndata(adata2_on_disk) | ||
|
|
||
| # Test add_anndatas raises error when passing list with mismatched var | ||
| loader = Loader(chunk_size=10, preload_nchunks=4, batch_size=20) | ||
| with pytest.raises(ValueError, match="All datasets must have identical var DataFrames"): | ||
| loader.add_anndatas([adata1_on_disk, adata2_on_disk]) |
Collaborator
There was a problem hiding this comment.
Let's make these subtests https://docs.pytest.org/en/stable/how-to/subtests.html
Collaborator
There was a problem hiding this comment.
Also add_datasets tests
Comment on lines
+402
to
+403
| var | ||
| :class:`~pandas.DataFrame` var, generally from :attr:`anndata.AnnData.var`. |
Collaborator
There was a problem hiding this comment.
Maybe mention here and in add_anndata that the added var must match any previously added ones
ilan-gold
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should implement: #109