perf: use pinned memory with preload_to_gpu#161
Merged
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 92.10% 92.79% +0.69%
==========================================
Files 11 11
Lines 937 944 +7
==========================================
+ Hits 863 876 +13
+ Misses 74 68 -6
🚀 New features to boost your workflow:
|
felix0097
reviewed
Mar 17, 2026
| ] | ||
| ) | ||
|
|
||
| def get_kwargs(z: zarr.Array) -> dict: |
Collaborator
There was a problem hiding this comment.
why do you use a get_kwargs function here and not above?
Collaborator
Author
There was a problem hiding this comment.
Because it's used in the list comprehension, but yea, good point for a refactor!
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83