Skip to content

(chore): Add SIM lints#1963

Merged
flying-sheep merged 3 commits into
mainfrom
pa/sim-lints
Apr 11, 2025
Merged

(chore): Add SIM lints#1963
flying-sheep merged 3 commits into
mainfrom
pa/sim-lints

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Apr 11, 2025

See #1241

@flying-sheep flying-sheep added skip-gpu-ci needs retroactive review This PR has been merged but could use some eyes on it labels Apr 11, 2025
@flying-sheep flying-sheep added this to the 0.12.0 milestone Apr 11, 2025
@flying-sheep flying-sheep mentioned this pull request Apr 11, 2025
19 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 72.88136% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (16ac42e) to head (662982f).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_core/anndata.py 53.84% 6 Missing ⚠️
...anndata/experimental/multi_files/_anncollection.py 60.00% 4 Missing ⚠️
src/anndata/_io/specs/methods.py 25.00% 3 Missing ⚠️
src/anndata/_io/read.py 80.00% 1 Missing ⚠️
src/anndata/experimental/pytorch/_annloader.py 0.00% 1 Missing ⚠️
src/anndata/tests/helpers.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
- Coverage   86.86%   85.03%   -1.83%     
==========================================
  Files          47       47              
  Lines        6920     6870      -50     
==========================================
- Hits         6011     5842     -169     
- Misses        909     1028     +119     
Files with missing lines Coverage Δ
src/anndata/_core/aligned_df.py 95.83% <ø> (ø)
src/anndata/_core/merge.py 84.38% <100.00%> (-9.59%) ⬇️
src/anndata/_core/raw.py 75.53% <100.00%> (-4.61%) ⬇️
src/anndata/_core/sparse_dataset.py 92.53% <100.00%> (+0.16%) ⬆️
src/anndata/_io/h5ad.py 93.13% <100.00%> (+0.41%) ⬆️
src/anndata/_io/specs/lazy_methods.py 96.00% <ø> (ø)
src/anndata/_io/specs/registry.py 93.68% <100.00%> (-0.56%) ⬇️
src/anndata/_io/write.py 78.49% <100.00%> (ø)
src/anndata/_io/zarr.py 85.71% <100.00%> (-0.31%) ⬇️
src/anndata/compat/__init__.py 83.02% <100.00%> (-0.16%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

return MaskedArray(
values=elem["values"],
mask=elem["mask"] if "mask" in elem else None,
mask=elem.get("mask", None),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s the only one I wasn’t sure about, but this one’s covered by tests

@flying-sheep flying-sheep changed the title (chore) Add SIM lints (chore): Add SIM lints Apr 11, 2025
@flying-sheep flying-sheep merged commit 67bf88b into main Apr 11, 2025
15 of 16 checks passed
@flying-sheep flying-sheep deleted the pa/sim-lints branch April 11, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs retroactive review This PR has been merged but could use some eyes on it skip-gpu-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant