Skip to content

(chore): add bugbear and PIE lints#1967

Merged
flying-sheep merged 8 commits into
mainfrom
pa/bugbear-lints
Apr 12, 2025
Merged

(chore): add bugbear and PIE lints#1967
flying-sheep merged 8 commits into
mainfrom
pa/bugbear-lints

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Apr 11, 2025

See #1241

@flying-sheep flying-sheep added skip-gpu-ci needs retroactive review This PR has been merged but could use some eyes on it labels Apr 11, 2025
@flying-sheep flying-sheep added this to the 0.12.0 milestone Apr 11, 2025
@flying-sheep flying-sheep mentioned this pull request Apr 11, 2025
19 tasks
@flying-sheep flying-sheep enabled auto-merge (squash) April 11, 2025 16:45
@flying-sheep flying-sheep disabled auto-merge April 11, 2025 16:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (9fccaf5) to head (c67799a).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/utils.py 58.33% 5 Missing ⚠️
src/anndata/_io/write.py 0.00% 4 Missing ⚠️
src/anndata/_io/zarr.py 0.00% 2 Missing ⚠️
...anndata/experimental/multi_files/_anncollection.py 0.00% 2 Missing ⚠️
src/anndata/_io/specs/methods.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   87.17%   85.06%   -2.12%     
==========================================
  Files          47       47              
  Lines        6830     6848      +18     
==========================================
- Hits         5954     5825     -129     
- Misses        876     1023     +147     
Files with missing lines Coverage Δ
src/anndata/_core/aligned_df.py 95.91% <100.00%> (+0.08%) ⬆️
src/anndata/_core/anndata.py 83.09% <100.00%> (+0.06%) ⬆️
src/anndata/_core/merge.py 84.41% <100.00%> (-9.55%) ⬇️
src/anndata/_core/sparse_dataset.py 92.55% <100.00%> (+0.02%) ⬆️
src/anndata/_core/storage.py 89.13% <100.00%> (ø)
src/anndata/_core/views.py 85.40% <ø> (-5.58%) ⬇️
src/anndata/_io/__init__.py 100.00% <100.00%> (ø)
src/anndata/_io/h5ad.py 93.17% <100.00%> (+0.03%) ⬆️
src/anndata/_io/read.py 81.77% <100.00%> (+0.19%) ⬆️
src/anndata/_io/specs/lazy_methods.py 96.00% <100.00%> (ø)
... and 12 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

@flying-sheep flying-sheep Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a lot of zipping going on, I didn’t look at each individually, assuming they’re all well-tested.

If I introduced any bug in the whole ordeal, it’s here.

@flying-sheep flying-sheep enabled auto-merge (squash) April 12, 2025 08:59
@flying-sheep flying-sheep merged commit 089ed92 into main Apr 12, 2025
21 of 25 checks passed
@flying-sheep flying-sheep deleted the pa/bugbear-lints branch April 12, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs retroactive review This PR has been merged but could use some eyes on it skip-gpu-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant