Update state plotting#1177
Merged
WeilerP merged 3 commits intoscverse:mainfrom Mar 15, 2024
Merged
Conversation
Add outline if plotted in same plot.
Update ground truth figures for unit tests using new API.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 80.77% 80.78% +0.01%
==========================================
Files 51 51
Lines 8607 8612 +5
Branches 2237 2237
==========================================
+ Hits 6952 6957 +5
Misses 1102 1102
Partials 553 553
|
michalk8
requested changes
Mar 14, 2024
Collaborator
michalk8
left a comment
michalk8
left a comment
There was a problem hiding this comment.
Just one change, after the pass, lgtm, thank you!
Refactor adding `"nan"` as a category.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please search among the Pull requests before creating one.
Description
Closes
Closes #1176.