Minor rewording of precommit docs#151
Merged
Merged
Conversation
|
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
ivirshup
requested review from
flying-sheep and
grst
and removed request for
flying-sheep
flying-sheep
requested changes
Feb 22, 2023
Member
Author
|
Rewrote some of the relevant sections. Test failure seems to be codecov on the instance repo? |
Collaborator
|
The ruff link renders incorrectly |
flying-sheep
requested changes
Feb 23, 2023
Collaborator
|
@flying-sheep, are you happy with this now? |
flying-sheep
approved these changes
Mar 8, 2023
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
I’m happy! just wanted to make sure everyone is aware of the changed terminology
Member
Author
|
Thanks for cleaning this up @grst and @flying-sheep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapses ruff checks into other pre commit checks.
Unifies section on how to modify pre-commit checks.