Fix root logging level being set to INFO for all packages#298
Merged
Conversation
Use a named logger ('decoupler') instead of logging.basicConfig() so
importing decoupler no longer affects the logging level of other packages.
Closes #296
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 78 78
Lines 4075 4079 +4
=======================================
+ Hits 3843 3847 +4
Misses 232 232
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logging.basicConfig()in_log.pywith a nameddecouplerlogger so importing decoupler no longer sets the root logging level to INFO for all packagesCloses #296
Test plan
import decouplertests/pp/test_net.pyandtests/ds/test_toy.pypass🤖 Generated with Claude Code