Drop cuml.thirdparty_adapters.check_array dependency#660
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 88.17% 88.15% -0.02%
==========================================
Files 96 96
Lines 7060 7067 +7
==========================================
+ Hits 6225 6230 +5
- Misses 835 837 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuml 26.06 removed check_array from cuml.thirdparty_adapters (rapidsai/cuml#8052), breaking the rapids-prerelease CI matrix. Replaces the two check_array_cuml(init_coords, dtype=np.float32, accept_sparse=False) call sites in _draw_graph.py and _umap.py with a small local _validate_init_pos helper in tools/_utils.py — same behavior (reject sparse, coerce to cupy float32, ensure 2D), no cuml-internal dependency.