Skip to content

Drop cuml.thirdparty_adapters.check_array dependency#660

Merged
Intron7 merged 3 commits into
mainfrom
fix/cuml-26.06-check-array-removal
May 15, 2026
Merged

Drop cuml.thirdparty_adapters.check_array dependency#660
Intron7 merged 3 commits into
mainfrom
fix/cuml-26.06-check-array-removal

Conversation

@Intron7
Copy link
Copy Markdown
Member

@Intron7 Intron7 commented May 15, 2026

cuml 26.06 removed check_array from cuml.thirdparty_adapters (rapidsai/cuml#8052), breaking the rapids-prerelease CI matrix. Replaces the two check_array_cuml(init_coords, dtype=np.float32, accept_sparse=False) call sites in _draw_graph.py and _umap.py with a small local _validate_init_pos helper in tools/_utils.py — same behavior (reject sparse, coerce to cupy float32, ensure 2D), no cuml-internal dependency.

@Intron7 Intron7 enabled auto-merge (squash) May 15, 2026 10:46
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.15%. Comparing base (2926263) to head (b004385).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rapids_singlecell/tools/_utils.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   88.17%   88.15%   -0.02%     
==========================================
  Files          96       96              
  Lines        7060     7067       +7     
==========================================
+ Hits         6225     6230       +5     
- Misses        835      837       +2     
Files with missing lines Coverage Δ
src/rapids_singlecell/tools/_draw_graph.py 97.29% <100.00%> (ø)
src/rapids_singlecell/tools/_umap.py 81.53% <100.00%> (-0.28%) ⬇️
src/rapids_singlecell/tools/_utils.py 78.23% <75.00%> (-0.19%) ⬇️

@Intron7 Intron7 merged commit 178dffc into main May 15, 2026
26 of 34 checks passed
@Intron7 Intron7 deleted the fix/cuml-26.06-check-array-removal branch May 15, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants