ci: bump codecov-action to v6 and fail CI on upload error#690
Merged
Conversation
codecov-action below v6.0.2 verifies the codecov CLI against Codecov's old Keybase key, which they bricked after migrating accounts, so uploads now fail with "Could not verify signature". v6 (= 6.0.2) ships the updated key. Also sets fail_ci_if_error: true (the cookiecutter-scverse template default) so a broken coverage upload surfaces as a CI failure instead of passing silently. Ref: codecov/codecov-action#1956 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 104 104
Lines 8964 8964
=======================================
Hits 8094 8094
Misses 870 870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to every codecov upload step in this repo:
@v6. Versions below 6.0.2 verify the codecov CLI binary against Codecov's old Keybase key, which they bricked after migrating accounts, so uploads now fail withCould not verify signature.@v6(= 6.0.2) ships the updated key.fail_ci_if_error: true. Matches thecookiecutter-scversetemplate default so a broken upload fails CI loudly instead of passing silently.Ref: codecov/codecov-action#1956