Backport PR #3607 on branch 1.11.x ((chore): derive CI matrix from hatch env)#3647
Conversation
|
@ilan-gold what do you think: louvain 0.7.1 makes things crash, but 0.7.2 requires igraph≥0.9.5. should I bump things until everything works together or disable louvain for the low-vers job in this backport? |
Sorry, isn't the igraph minimum version higher than 0.9.5? Why is this problematic? |
|
ah my mistake, I read uv’s error wrong. What it really says is
so louvain 0.7.2 introduced1 an upper bound that’s incompatible, which means that I guess it would be valid to say “scanpy 0.11.x works with (louvain==0.7.2 and igraph==0.9.5) or (leiden==0.9.0 and igraph==0.10.8)”, but that’s getting too far into the weeds. Let’s just define one baseline for low versions and that’s it. Footnotes
|
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
|
The fix seems reasonable @flying-sheep. Another option would be to introduce a temporary fix into the |
Backports #3607