Open
Conversation
10 tasks
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Member
Author
|
local timings
|
flying-sheep
commented
Mar 20, 2026
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/9de11b14a0b4cac36c256806ce906d9cbbe1a96a..d748f0b5640e22732beb6ab169ff47b1ffbc83e0 More details: https://github.com/scverse/scanpy/pull/4004/checks?check_run_id=67912471934 |
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
for more information, see https://pre-commit.ci
ilan-gold
approved these changes
Mar 20, 2026
Comment on lines
+1122
to
+1133
| for i in numba.prange(len(rows)): | ||
| if not mask[i]: | ||
| continue | ||
| thread = numba.get_thread_id() | ||
| _downsample_array_inner( | ||
| rows[i], | ||
| targets[i], | ||
| rng=rngs[thread] if rngs is not None else None, | ||
| seed=seed, | ||
| replace=replace, | ||
| inplace=True, | ||
| ) |
Contributor
There was a problem hiding this comment.
cc @selmanozleyen re: my comments on scverse/squidpy#1125
This is also a good option - let numba handle the threading for you
| replace: bool, | ||
| ) -> T: | ||
| total_counts = int(total_counts) | ||
| total = x.sum() |
Contributor
There was a problem hiding this comment.
should use fau to prepare for scverse/fast-array-utils#155 maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed to implement
np.random.Generator.choicefor this.