Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 97.59% 97.47% -0.12%
==========================================
Files 5 5
Lines 208 238 +30
==========================================
+ Hits 203 232 +29
- Misses 5 6 +1
🚀 New features to boost your workflow:
|
ilia-kats
requested changes
Apr 28, 2026
Collaborator
ilia-kats
left a comment
There was a problem hiding this comment.
Can you add a changelog entry? Otherwise looks good to me.
Member
Author
|
sure! I’ll have to change a bit more though, I’ll mark it as ready when it is |
Member
Author
ilia-kats
requested changes
Apr 28, 2026
Collaborator
ilia-kats
left a comment
There was a problem hiding this comment.
awesome, thanks! Just two minor nitpicks, otherwise it's good to go
Co-authored-by: ilia-kats <ilia-kats@gmx.net>
ilia-kats
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add annotations to
overrideand a"scverse"docstring style which is “numpy but parameter types are only in the annotations and not in the docstring”. Scanpy enforces this style and doesn’t acceptparam : typesyntax in the docstring.This is a breaking change because it also removes the default for
docstring_style, which I asked for in #16.alternatives
"scverse"style, we could have an independent option for “no types in param docstrings” (e.g.docstring_style="numpy", types_in_docstring=False)