Open
Conversation
Draft
ilia-kats
requested changes
Apr 16, 2026
Collaborator
ilia-kats
left a comment
ilia-kats
left a comment
There was a problem hiding this comment.
Thanks, missed that part when converting from a dataclass to the string subclass.
| assert lines[2].startswith(".. version-deprecated") | ||
| if msg is not None: | ||
| if msg is None: | ||
| assert len(lines) == 3 |
Collaborator
There was a problem hiding this comment.
lines contains all lines of the docstring, not just the deprecation message, which is why the tests are failing. So this should be something like len(lines_orig) + 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test code so far generated
which is certainly not intended