Skip to content

Conversation

@talashuach
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,741 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A paragraph above describing why you're doing this would be better than comments. Generally, using text cells is better than comments. Would be great to do this in all relevant cases


Reply via ReviewNB

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, why not also add a pure RNA pbmc dataset from 10x? We have a function in scvi.data that gets anndata from like 25 different 10x datasets

@@ -0,0 +1,741 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should comment on whether the names of the categories matters


Reply via ReviewNB

@@ -0,0 +1,741 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be good for a warning box, if you donwload one of the tutorials with a warniung box (the intro one I think), then double click the cell and it gives you the HTML you need


Reply via ReviewNB

@@ -0,0 +1,741 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to show imputed values and visualize pbmc marker genes


Reply via ReviewNB

@adamgayoso adamgayoso merged commit 30f5fa2 into master Aug 21, 2021
@adamgayoso adamgayoso deleted the multivi branch August 21, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants