-
Notifications
You must be signed in to change notification settings - Fork 51
Improvements/fixes: merscope reader #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 41.92% 41.54% -0.38%
==========================================
Files 16 16
Lines 854 869 +15
==========================================
+ Hits 358 361 +3
- Misses 496 508 +12
|
LucaMarconato
approved these changes
Jul 31, 2023
Member
LucaMarconato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for the refinement!
lucas-diedrich
pushed a commit
to lucas-diedrich/spatialdata-io
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made a few improvements and fixes for the merscope reader:
SpatialDataobject. This is something I discussed with @LucaMarconato to better understand what was called "region" in theTableModel.parse. Now,region=f"{dataset_id}_polygons", and I create another variable (vizgen_region) to denote the region name used by vizgen, and not mix the two. It now works as intended..zarr, because I was not making chunks. I used the same logic as in thexeniumreader with theimread_kwargsandimage_models_kwargsvariables.micronspace by default (instead of the pixels space), which feels more natural because we use to deal with distances in microns.Let me know!