Skip to content

Conversation

@MeyerBender
Copy link
Contributor

Small logic fix in _make_patch_from_multipolygon() (in pl/utils.py) that addresses issue #505

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (07e0f0f) to head (ef29c07).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   84.42%   84.81%   +0.38%     
==========================================
  Files           8        8              
  Lines        2131     2133       +2     
==========================================
+ Hits         1799     1809      +10     
+ Misses        332      324       -8     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/utils.py 80.85% <96.66%> (+0.66%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis
Copy link
Member

Hey @MeyerBender, made a few changes to your solution and added tests. Could you confirm it still works in your other package?

@timtreis timtreis self-requested a review November 15, 2025 17:23
@MeyerBender
Copy link
Contributor Author

Hi @timtreis, it appears to be working, thanks a lot!

@timtreis
Copy link
Member

Okay, great! Then I'll merge. I'll probably release a new version beginning of next week, there are 2 more PRs that I'd like to have merged by then.

@timtreis timtreis merged commit 04e17d4 into scverse:main Nov 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants