-
Notifications
You must be signed in to change notification settings - Fork 18
Enabled rendering of shapes with multiple holes #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 84.42% 84.81% +0.38%
==========================================
Files 8 8
Lines 2131 2133 +2
==========================================
+ Hits 1799 1809 +10
+ Misses 332 324 -8
🚀 New features to boost your workflow:
|
|
Hey @MeyerBender, made a few changes to your solution and added tests. Could you confirm it still works in your other package? |
|
Hi @timtreis, it appears to be working, thanks a lot! |
|
Okay, great! Then I'll merge. I'll probably release a new version beginning of next week, there are 2 more PRs that I'd like to have merged by then. |
Small logic fix in
_make_patch_from_multipolygon()(inpl/utils.py) that addresses issue #505