Skip to content

Conversation

@timtreis
Copy link
Member

@timtreis timtreis commented Nov 18, 2025

Now raising errors on missing input and if no table at all annotates the element.

In the process, I noticed we sometimes warn from our logger and sometimes from warnings, so I got rid of warnings. Then, I had to adjust the capturing of the logged messages, so I added that helper as well.

@timtreis timtreis linked an issue Nov 18, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 74.57627% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.33%. Comparing base (17df374) to head (adcb9a5).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/render.py 53.12% 15 Missing ⚠️
src/spatialdata_plot/pl/utils.py 79.68% 13 Missing ⚠️
src/spatialdata_plot/_logging.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   83.88%   83.33%   -0.56%     
==========================================
  Files           8        8              
  Lines        2259     2322      +63     
==========================================
+ Hits         1895     1935      +40     
- Misses        364      387      +23     
Files with missing lines Coverage Δ
src/spatialdata_plot/_logging.py 91.66% <90.90%> (-1.20%) ⬇️
src/spatialdata_plot/pl/utils.py 79.52% <79.68%> (-0.04%) ⬇️
src/spatialdata_plot/pl/render.py 88.57% <53.12%> (-2.77%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis timtreis linked an issue Nov 19, 2025 that may be closed by this pull request
@timtreis
Copy link
Member Author

@LucaMarconato I assume this will have implications in our tutorials if we're blindly plotting elements that are not annotated.

@timtreis timtreis merged commit 35b5e20 into main Nov 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail if color or table do not exist Shall we throw an exception or a warning when a color is missing?

3 participants