Skip to content

Conversation

@dgarcia360
Copy link

Updates docs theme to the latest version.

Details: https://sphinx-theme.scylladb.com/stable/upgrade/CHANGELOG.html#id1

@annastuchlik
Copy link

@Lorak-mmk Could you review and merge this PR?

@Lorak-mmk
Copy link
Collaborator

Version bump in pyproject.toml is missing - only lockfile was updated.

@annastuchlik
Copy link

@dgarcia360 Please see the above.

@dgarcia360
Copy link
Author

dgarcia360 commented Feb 25, 2025

@Lorak-mmk It's not strictly necessary. The pyproject specifies sphinx-scylladb-theme = "^1.8.1" (greater than or equal to 1.8.1) and the Poetry lock file locks the latest version (1.8.5).

@Lorak-mmk
Copy link
Collaborator

@Lorak-mmk It's not strictly necessary. The pyproject specifies sphinx-scylladb-theme = "^1.8.1" (greater than or equal to 1.8.1) and the Poetry lock file locks the latest version (1.8.5).

If this is the case then why did PR in Rust Driver also update the version in pyproject.toml? https://github.com/scylladb/scylla-rust-driver/pull/1175/files
This is also the case in Java Driver, but not Python Driver.

I'm not saying one of those approaches is wrong, I'd just like it to be consistent. I propose to stick to updating the version in pyproject.toml too, its more explicit.

@dgarcia360
Copy link
Author

@Lorak-mmk updated 6cf4fdc

@Lorak-mmk Lorak-mmk merged commit 994b8ca into scylladb:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants