fix: correct protobuf wire type for ConfigHash and SecretKeyHashes#462
Merged
Merged
Conversation
ConfigHash (string) and SecretKeyHashes (map[string]string) were tagged with protobuf wire type `varint`, which is only valid for integer scalars. The correct wire type for string and map fields is `bytes`. Using `varint` for these fields causes protobuf serialization and deserialization (e.g. etcd storage in an aggregated API server) to produce garbled data or return a decode error at runtime. Change both tags from `varint` to `bytes` to match the Go types. Co-authored-by: Cursor <cursoragent@cursor.com>
henderiw
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigHash(string) andSecretKeyHashes(map[string]string) inSensitiveConfigSpecwere tagged with protobuf wire typevarintvarintis only valid for integer scalars;stringandmapfields require wire typebytesvarinttobytesRoot cause
The other fields in the struct (
Lifecycle,Payload, etc.) already usebytescorrectly; these two were a copy-paste mistake from integer fields above them.Test plan
SensitiveConfigwith non-emptyConfigHashandSecretKeyHashesproduces identical valuessensitivebranch, so no migration needed)Made with Cursor