ci: replace paired-test label with Pairs-with body parsing for integration#463
Merged
Conversation
…ation Drop the label + same-branch-name convention. CI now resolves paired repo refs from "Pairs-with: sdcio/<repo>#<PR>" lines in the PR description: - sdcio/config-server#NNN → branch → full SHA (GHCR image tag) - sdcio/integration-tests#NNN → branch name (checkout ref for test code) Falls back to main for any repo not listed. workflow_dispatch keeps explicit override inputs (configserver_version, integration_tests_ref) for manual runs. Branch name alignment across repos is no longer required. Passes integration_tests_ref to single.yml (sdcio/integration-tests#107). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
paired-testlabel + same-branch-name convention introduced in #447 with a simpler, more explicit mechanism:Pairs-with:trailers in the PR body.How it works
Add one line per paired repo to the PR description:
CI (
resolve-paired-refsjob) reads the PR body, looks up each referenced PR number, resolves its branch to the required ref format, and passes it to the integration-tests reusable workflow:sdcio/config-serversdcio/integration-testsNo
Pairs-with:lines → all paired repos fall back tomain.Changes
resolve-configserver-versionjob (label + branch-name lookup)resolve-paired-refsjob (PR body parsing, covers both config-server and integration-tests)integration_tests_refworkflow_dispatch input (manual override)integration_tests_reftosingle.yml(requires ci: add integration_tests_ref input to reusable single.yml workflow integration-tests#107 merged first)What's gone
paired-testlabel needed on data-server PRspaired-testlabel on this repo can be deleted after both companion PRs mergeMerge order
integration_tests_refinput tosingle.yml)Stop()errors in GNMI stream tests #455)Example PR body for a 3-repo feature
Branch names on config-server and integration-tests can be anything — the PR number is the link.
Companion PRs:
Stop()errors in GNMI stream tests #455)Made with Cursor